xfs
[Top] [All Lists]

Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field

To: Geoffrey Wehrman <gwehrman@xxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 22 Aug 2013 13:19:10 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130822161456.GB23510@xxxxxxx>
References: <1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <20130819201940.516942026@xxxxxxx> <5212AA1D.3000809@xxxxxxxxxxx> <52137D3D.8060205@xxxxxxx> <20130821000624.GO6023@dastard> <20130821170336.GJ5262@xxxxxxx> <20130822020226.GR6023@dastard> <20130822161456.GB23510@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Gents,

On Thu, Aug 22, 2013 at 11:14:56AM -0500, Geoffrey Wehrman wrote:
> On Thu, Aug 22, 2013 at 12:02:26PM +1000, Dave Chinner wrote:
> | I'm very, very, very unhappy about how this situation is unfolding.
> 
> As am I.

Mark provided some mkfs code to test the v4 feature bit with, and it
worked fine for me.

Given that we are protected by a feature bit, I feel that pulling in the
v4 feature is considerably less risky than what we did in 3.10, with
Dave still cleaning up his mess in -rc6, so go ahead and call me
reckless:  I've pulled in both v4 and v5 versions of this code.

Mark, please post your mkfs code ASAP, even though Dave hasn't reposted
his userspace series yet.

Everybody gets his code in and nobody is happy.

-Ben

<Prev in Thread] Current Thread [Next in Thread>