xfs
[Top] [All Lists]

Re: [PATCH] xfs_db: add header to freesp -d output

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_db: add header to freesp -d output
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 22 Aug 2013 09:05:30 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <521541EF.1000604@xxxxxxxxxx>
References: <521541EF.1000604@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/21/13 17:40, Eric Sandeen wrote:
Today, xfs_db's freesp -d command dumps out a bunch of numbers:

# xfs_db -c "freesp -d" /dev/sdb1
        0        4        1
        0        5        1
        0        6        1
        0        7        1
        0       12   174772
...

which are not useful to the non-code-reading user.
Add some headers:

# xfs_db -c "freesp -d" /dev/sdb1
     agno    agbno      len
        0        4        1
        0        5        1
        0        6        1
        0        7        1
        0       12   174772
...

so there's at least some context.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

p.s. - If folks want different strings, I'm game.


Seems like just yesterday, some reviewer was concerned about the verbosity of table headers... wait it was yesterday! Gawd, I love irony.
:)

Geoffrey comment len -> length is fine too.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>