xfs
[Top] [All Lists]

Re: [PATCH] xfs_db: add header to freesp -d output

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_db: add header to freesp -d output
From: Geoffrey Wehrman <gwehrman@xxxxxxx>
Date: Thu, 22 Aug 2013 09:03:18 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <521541EF.1000604@xxxxxxxxxx>
References: <521541EF.1000604@xxxxxxxxxx>
User-agent: Mutt/1.5.14 (2007-02-12)
On Wed, Aug 21, 2013 at 05:40:47PM -0500, Eric Sandeen wrote:
| Today, xfs_db's freesp -d command dumps out a bunch of numbers:
| 
| # xfs_db -c "freesp -d" /dev/sdb1
|        0        4        1
|        0        5        1
|        0        6        1
|        0        7        1
|        0       12   174772
| ...
| 
| which are not useful to the non-code-reading user.
| Add some headers:
| 
| # xfs_db -c "freesp -d" /dev/sdb1
|     agno    agbno      len
|        0        4        1
|        0        5        1
|        0        6        1
|        0        7        1
|        0       12   174772
| ...
| 
| so there's at least some context.
| 
| Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
| ---
| 
| p.s. - If folks want different strings, I'm game.

The format is consistent with the "dumpflag" format in addtohist().  I
like your choice of strings, except I suggest "length" in place of
"len".  The space is available.


-- 
Geoffrey Wehrman  651-683-5496  gwehrman@xxxxxxx

<Prev in Thread] Current Thread [Next in Thread>