Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()

[Rich Johnston <rjohnston@xxxxxxx>]

On 08/21/2013 10:28 AM, Eric Sandeen wrote:
> On 8/21/13 9:28 AM, Mark Tinguely wrote:
> > On 08/20/13 18:14, Eric Sandeen wrote:
> > > 3ac87fbf xfsprogs: fix inode crash in xfs_repair
> > >
> > > un-static'd alloc_ex_data and used it in phase6.c,
> > > but didn't put a prototype in a header, so:
> > >
> > >    phase6.c: In function ‘mk_orphanage’:
> > >    phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
> > >
> > > Fix it...
> > >
> > > Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
> > > ---
> >
> > Thanks and sorry. I knew it and hoped to get it in before it got committed.
> Eh, it happens.
>
> Minor demerit for Rich for not catching it before commit, either ;)
***rjohnston: hides head in shame and vows to improve

> -Eric (who has never, NEVER made a mistake like that)
>
> > --Mark.
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@xxxxxxxxxxx
> > http://oss.sgi.com/mailman/listinfo/xfs
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs