xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Wed, 21 Aug 2013 12:14:17 -0500
Cc: Mark Tinguely <tinguely@xxxxxxx>, "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Delivered-to: linux-xfs@xxxxxxxxxxx
In-reply-to: <5214DCAA.9090703@xxxxxxxxxxx>
References: <5213F849.7080308@xxxxxxxxxx> <5214CE82.3040707@xxxxxxx> <5214DCAA.9090703@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 08/21/2013 10:28 AM, Eric Sandeen wrote:
On 8/21/13 9:28 AM, Mark Tinguely wrote:
On 08/20/13 18:14, Eric Sandeen wrote:
3ac87fbf xfsprogs: fix inode crash in xfs_repair

un-static'd alloc_ex_data and used it in phase6.c,
but didn't put a prototype in a header, so:

   phase6.c: In function ‘mk_orphanage’:
   phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’

Fix it...

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---


Thanks and sorry. I knew it and hoped to get it in before it got committed.

Eh, it happens.

Minor demerit for Rich for not catching it before commit, either ;)

***rjohnston: hides head in shame and vows to improve


-Eric (who has never, NEVER made a mistake like that)


--Mark.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>