xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 21 Aug 2013 10:28:42 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>
Delivered-to: linux-xfs@xxxxxxxxxxx
In-reply-to: <5214CE82.3040707@xxxxxxx>
References: <5213F849.7080308@xxxxxxxxxx> <5214CE82.3040707@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 8/21/13 9:28 AM, Mark Tinguely wrote:
> On 08/20/13 18:14, Eric Sandeen wrote:
>> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
>>
>> un-static'd alloc_ex_data and used it in phase6.c,
>> but didn't put a prototype in a header, so:
>>
>>   phase6.c: In function ‘mk_orphanage’:
>>   phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
>>
>> Fix it...
>>
>> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
>> ---
> 
> 
> Thanks and sorry. I knew it and hoped to get it in before it got committed.

Eh, it happens.

Minor demerit for Rich for not catching it before commit, either ;)

-Eric (who has never, NEVER made a mistake like that)

> 
> --Mark.
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>