xfs
[Top] [All Lists]

Re: [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV

To: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Subject: Re: [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 20 Aug 2013 23:43:57 -0700
Cc: xfs@xxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Abhijith Das <adas@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1375828029-26360-2-git-send-email-sekharan@xxxxxxxxxx>
References: <1375828029-26360-1-git-send-email-sekharan@xxxxxxxxxx> <1375828029-26360-2-git-send-email-sekharan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Sorry for being late to the game, but I don not like the in-kernel
interface here at all.  Given that Q_XGETQSTATV is a strict superset
of Q_XGETQSTAT there is no need for the second method - just always
fill out the larger in-kernel structure and only copy the smaller
information to userspace for the Q_XGETSTAT case.  That keeps the amount
of code required in the implementations of the methods low and follows
the model used elsewhere in the kernel (e.g. stat and statfs)

<Prev in Thread] Current Thread [Next in Thread>