xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 21 Aug 2013 10:07:04 +1000
Cc: "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>
Delivered-to: linux-xfs@xxxxxxxxxxx
In-reply-to: <5213F849.7080308@xxxxxxxxxx>
References: <5213F849.7080308@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Aug 20, 2013 at 06:14:17PM -0500, Eric Sandeen wrote:
> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
> 
> un-static'd alloc_ex_data and used it in phase6.c,
> but didn't put a prototype in a header, so:
> 
>  phase6.c: In function âmk_orphanageâ:
>  phase6.c:943: warning: implicit declaration of function âalloc_ex_dataâ
> 
> Fix it...
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/repair/incore.h b/repair/incore.h
> index 8a578b5..38caa6d 100644
> --- a/repair/incore.h
> +++ b/repair/incore.h
> @@ -483,6 +483,11 @@ void             set_inode_parent(ino_tree_node_t *irec, 
> int ino_offset,
>  xfs_ino_t    get_inode_parent(ino_tree_node_t *irec, int ino_offset);
>  
>  /*
> + * Allocate extra inode data
> + */
> +void         alloc_ex_data(ino_tree_node_t *irec);
> +
> +/*
>   * bmap cursor for tracking and fixing bmap btrees.  All xfs btrees number
>   * the levels with 0 being the leaf and every level up being 1 greater.
>   */

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>