xfs
[Top] [All Lists]

Re: linux-next: build failure after merge of the final tree

To: Dwight Engen <dwight.engen@xxxxxxxxxx>
Subject: Re: linux-next: build failure after merge of the final tree
From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 20 Aug 2013 22:46:30 +0200
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, David Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, Gao feng <gaofeng@xxxxxxxxxxxxxx>, Jeremy Kerr <jk@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, cbe-oss-dev@xxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130820120702.000b044e@xxxxxxxxxx>
References: <20130820172052.1f0d89ddf6a1a40ef70333fd@xxxxxxxxxxxxxxxx> <20130820120702.000b044e@xxxxxxxxxx>
User-agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; )
On Tuesday 20 August 2013, Dwight Engen wrote:
> diff --git a/arch/powerpc/platforms/cell/spufs/inode.c 
> b/arch/powerpc/platforms/cell/spufs/inode.c
> index f390042..90fb308 100644
> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -620,12 +620,12 @@ spufs_parse_options(struct super_block *sb, char 
> *options, struct inode *root)
>                 case Opt_uid:
>                         if (match_int(&args[0], &option))
>                                 return 0;
> -                       root->i_uid = option;
> +                       root->i_uid = make_kuid(&init_user_ns, option);
>                         break;
>                 case Opt_gid:
>                         if (match_int(&args[0], &option))
>                                 return 0;
> -                       root->i_gid = option;
> +                       root->i_gid = make_kgid(&init_user_ns, option);
>                         break;
>                 case Opt_mode:
>                         if (match_octal(&args[0], &option))

Doesn't this mean the uid/gid is taken from the initial namespace rather than
from the namespace of the 'mount' process calling this? I think the logical
choice would be to have the UID be the one that gets passed here in the caller's
namespace.

        Arnd

<Prev in Thread] Current Thread [Next in Thread>