[Top] [All Lists]

Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 19 Aug 2013 18:28:29 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130819201940.516942026@xxxxxxx>
References: <1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <20130819201940.516942026@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 8/19/13 3:19 PM, Mark Tinguely wrote:

<an attachment that doesn't show up on reply, moving d_type support to v4 
superblocks ;) >

Thanks, Mark!

Has you been able to test this at all?

I do still owe a promised xfstest - but for that, we'll need at least mkfs
& xfs_repair support.

Did you patch up mkfs to do basic tests of your kernelspace patch?

Talking to Dave, he reminds me of a few things this needs, if it's
going to be complete & compatible on V4:

* mkfs.xfs commandline option support & manpage updates
* xfs_db support (including version friendly-text output)
* XFS_IOC_FSGEOM support so that xfs_info can report the difference
* xfs_repair needs to know that it's a valid feature on V4

Some of that may overlap w/ things still needed on V5, but some is unique
to allowing it on V4.

Mark, do you plan to do some of those unique-to-V4 parts, too?

As an aside: I would support getting this feature onto V4 superblocks,
after we have confidence that all the bits are done, tested, and robust.

I still would really like to see it go forward in parallel on V5, and
not be blocked by the extra work needed for proper V4 integration.


<Prev in Thread] Current Thread [Next in Thread>