[Top] [All Lists]

Re: [PATCH] v2 xfsprogs: fix inode crash in xfs_repair

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] v2 xfsprogs: fix inode crash in xfs_repair
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Mon, 19 Aug 2013 11:06:36 -0500
Cc: <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130816181254.285296783@xxxxxxx>
References: <20130816181254.285296783@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
Thanks for the patch Mark, it has been committed.


commit 3ac87fbf6ac29494dc46134323733551aac1737c
Author: Mark Tinguely <tinguely@xxxxxxx>
Date:   Fri Aug 16 18:12:43 2013 +0000

    xfsprogs: fix inode crash in xfs_repair

    Adding the lost+found in phase 6 could allocate an inode from
    a new inode chunk. Since this chunk was not around in phase 3
    when the inode chunks are verificated and added to the avl tree,
    the avl tree look up will return a NULL pointer. This results
    in a NULL defererence and segmentation fault.

    Add the newly created inode chunk as if found in the chunk
    verification phase.

    Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
    Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>