xfs
[Top] [All Lists]

Re: [v6] xfstests: add a new test case for ext4 indirect-based file

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [v6] xfstests: add a new test case for ext4 indirect-based file
From: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Date: Fri, 16 Aug 2013 13:31:49 +0800
Cc: xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Zheng Liu <wenqing.lz@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=17JWqPS/rJjIx9o5p3lcJ23KOrLcfPGuazacl/8GD/4=; b=vbgasmfOh3l68Mxg7SrV2GtFFnJS4TKXfafnCcUKc+geRXatY09KUv409g2xJBSfhg LCVisrHNob/lhSUjwgfOVkbPff2196gfo7HFuAjvFTnH+LyAfsAHfZ2ij4CzsebSFqrP Jde2huIvokAtr0UsCVRNA+UwzYsyVCXUSI1jYCGE+1/BJawgkasOi2duF/9orapbWqaT Mz9OwNdDag5Z0hLFMm27O2LvnHw/GOYzEO8RzXJ4P9qjISBQI6JLUlQ9wwoiLKu9gfcm T/yqKmVbxmIbta5hRHHNDQc+B/ngkX+132WxGcPqlc3cH9OAZqDCLPoh14FjABXf0DGS vdvQ==
In-reply-to: <520D4F4B.9010908@xxxxxxx>
References: <1368676359-2404-1-git-send-email-wenqing.lz@xxxxxxxxxx> <520D4F4B.9010908@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 15, 2013 at 04:59:39PM -0500, Rich Johnston wrote:
> This has not been reviewed since your second revision.
> It looks good except you need to remove the changes to
> tests/generic/255 and rebase against the latest tree.
> 
> You can then include a:
> Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

Thanks for your review.  I have rebased the patch and the latest patch
has been sent out.  Could you please review it?

Thanks,
                                                - Zheng

> 
> Thanks
> --Rich
> 
> On 05/15/2013 10:52 PM, wenqing.lz wrote:
> >From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> >
> >After applied this commit (864688d3), xfstests #255 will not test a
> >file system that cannot support fallocate(2), such as a indirect-based
> >file in ext4.  So we need to add a new generic test case to test it.
> >
> >The difference between #255 and this test case is only to use pwrite to
> >allocate blocks.  Other filesystems should survive in this test case.
> >In the mean time, a new argument '-u' is added into _test_generic_punch
> >not to run unwritten tests.
> >
> And remove these 2 lines as they no longer apply.
> >Meanwhile this commit fixes a minor problem in #255 that testfile should
> >use $seq.$$ as testfile.
> >
> >Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> >
> >---
> >changelog:
> >  * rebase against the latest master of xfstests tree (Based-on Eric's 
> > patch).
> >
> >  common/punch          | 164 
> > ++++++++++++++++++++++++++-----------------------
> >  tests/generic/255     |   2 +-
> 
> 
> 

<Prev in Thread] Current Thread [Next in Thread>