Re: ***** SUSPECTED SPAM ***** [PATCH 50/50] xfs: use reference counts t

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: *** SUSPECTED SPAM *** [PATCH 50/50] xfs: use reference counts to free clean buffer items
From:	Ben Myers <bpm@xxxxxxx>
Date:	Thu, 15 Aug 2013 16:43:23 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1376304611-22994-51-git-send-email-david@xxxxxxxxxxxxx>
References:	<1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <1376304611-22994-51-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Mon, Aug 12, 2013 at 08:50:11PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When a transaction is cancelled and the buffer log item is clean in
> the transaction, the buffer log item is unconditionally freed. If
> the log item is in the AIL, however, this leads to a use after free
> condition as the item still has other users.
> 
> In this case, xfs_buf_item_relse() should only be called on clean
> buffer items if the reference count has dropped to zero. This
> ensures only the last user frees the item.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Applied.

<Prev in Thread]	Current Thread	[Next in Thread>
*** SUSPECTED SPAM *** [PATCH 50/50] xfs: use reference counts to free clean buffer items, (continued) *** SUSPECTED SPAM *** [PATCH 50/50] xfs: use reference counts to free clean buffer items, Dave Chinner Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Mark Tinguely Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Dave Chinner Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Mark Tinguely Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Dave Chinner Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Zhi Yong Wu Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Dave Chinner Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Mark Tinguely Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Mark Tinguely Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Dave Chinner Re: * SUSPECTED SPAM * [PATCH 50/50] xfs: use reference counts to free clean buffer items, Ben Myers <= *** SUSPECTED SPAM *** [PATCH 10/50] xfs: sync minor header differences needed by userspace., Dave Chinner *** SUSPECTED SPAM *** [PATCH 04/50] xfs: split out EFI/EFD log item format definition, Dave Chinner *** SUSPECTED SPAM *** [PATCH 32/50] xfs: xfs_filestreams.h doesn't need __KERNEL__, Dave Chinner *** SUSPECTED SPAM *** [PATCH 29/50] xfs: kill __KERNEL__ check for debug code in allocation code, Dave Chinner *** SUSPECTED SPAM *** [PATCH 34/50] xfs: make struct xfs_perag kernel only, Dave Chinner *** SUSPECTED SPAM *** [PATCH 18/50] xfs: split out attribute fork truncation code into separate file, Dave Chinner *** SUSPECTED SPAM *** [PATCH 45/50] xfs: avoid CIL allocation during insert, Dave Chinner Re: [PATCH 45/50] xfs: avoid CIL allocation during insert, Mark Tinguely *** SUSPECTED SPAM *** [PATCH 47/50] xfs: split the CIL lock, Dave Chinner *** SUSPECTED SPAM *** [PATCH 28/50] xfs: don't special case shared superblock mounts, Dave Chinner

Previous by Date:	Re: [PATCH 48/49] xfs: Add read-only support for dirent filetype field, Ric Wheeler
Next by Date:	Re: page fault scalability (ext3, ext4, xfs), Andy Lutomirski
Previous by Thread:	Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items, Dave Chinner
Next by Thread:	*** SUSPECTED SPAM *** [PATCH 10/50] xfs: sync minor header differences needed by userspace., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]