[Top] [All Lists]

Re: [PATCH 48/49] xfs: Add read-only support for dirent filetype field

To: Geoffrey Wehrman <gwehrman@xxxxxxx>
Subject: Re: [PATCH 48/49] xfs: Add read-only support for dirent filetype field
From: Ric Wheeler <rwheeler@xxxxxxxxxx>
Date: Thu, 15 Aug 2013 06:59:21 +0100
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130814184729.GA4604@xxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-49-git-send-email-david@xxxxxxxxxxxxx> <51F80FA8.4060304@xxxxxxx> <20130812005905.GK12779@dastard> <5208E243.9080403@xxxxxxx> <20130813005024.GS12779@dastard> <520A53E8.6030604@xxxxxxx> <20130814075042.GE6023@dastard> <20130814184729.GA4604@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 08/14/2013 07:47 PM, Geoffrey Wehrman wrote:
On Wed, Aug 14, 2013 at 05:50:42PM +1000, Dave Chinner wrote:
| On Tue, Aug 13, 2013 at 10:42:32AM -0500, Mark Tinguely wrote:
| > On 08/12/13 19:50, Dave Chinner wrote:
| > >On Mon, Aug 12, 2013 at 08:25:23AM -0500, Mark Tinguely wrote:
| > >>On 08/11/13 19:59, Dave Chinner wrote:
| > >>>On Tue, Jul 30, 2013 at 02:10:32PM -0500, Mark Tinguely wrote:
| > >>>>On 07/19/13 01:25, Dave Chinner wrote:
| > >>>>>From: Dave Chinner<dchinner@xxxxxxxxxx>
| > >>>>>
| > >>>>>Add support for the file type field in directory entries so that
| > >>>>>readdir can return the type of the inode the dirent points to to
| > >>>>>userspace without first having to read the inode off disk.
| .....
| > >>>>>Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
| > >>>>>---
| > >>>>>
| > >>>>
| > >>>>>+static inline int xfs_sb_version_hasftype(struct xfs_sb *sbp)
| > >>>>>+{
| > >>>>>+    return XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5&&
| > >>>>>+            xfs_sb_has_incompat_feature(sbp, 
| > >>>>>  }
| > >>>>>
| > >>>>
| > >>>>This feature should support inode version 2 and 3.
| > >>>
| > >>>Has nothing to do with the inode version number - it has to do with
| > >>>the directory structure being modified.
| > >>>
| > >>>We're changing the directory structure for CRCs, and this builds on
| > >>>top of that. It is essentially part of the V3 directory format, and
| > >>>should be treated as such. Suggesting that we retrofit and support a
| > >>>modified v2 directory format is close to insane - instead of only
| > >>>having to test v2 vs v3 directory formats, you're suggesting we
| > >>>support v2 vs v2+dtype vs v3 vs v3+dtype. We simply do not have the
| > >>>resources to adequately test and support such an explosion of
| > >>>filesystem configurations.
| > >>>
| > >>>We've had this discussion before - new on-disk features go into the
| > >>>v5 superblock format - the v4 superblock format from this point
| > >>>onwards is essentially legacy support from an upstream development
| > >>>perspective.
| ....
| > >>>That said, there's nothing to stop anyone from backporting such a
| > >>>feature to an older kernel and maintaining it themselves - it's open
| > >>>source software. But the idea that development should be constrained
| > >>>by having to support both old and new formats is wrong - the old v4
| > >>>format should be considered stable and we need think very hard about
| > >>>changing it at all now, especially as much of the development focus
| > >>>is now shifting to taking advantage of the additions to the v5
| > >>>format....
| > >>
| > >>I guess we need more time to argue this out. It is not going into
| > >>Linux 3.12 as a crc feature only.
| > >
| > >Seriously?
| >
| > yes seriously.
| Great, another random roadblock from the XFS maintainers to deal
| with.

The addition of the file type field to directory entries is a great
new feature.  Your implementation of adding a "hidden" byte to the name
field is especially clever.  This is a feature that can benefit both
dir2 and dir3 format filesystems and is completely independent of your
CRC and self describing metadata feature work.  I understand that you
are not interested in porting the capability to dir2 format filesystems
yourself and do not have the resources to provide the associated testing
and support.  Myself and others within SGI have discussed these issues,
and we are willing to take on the work ourselves rather than have this
feature go only into v5 superblock filesystems where the feature is only
accessible to those who are willing to risk using experimental code.
Given that SGI will be doing the work to support the file type field
in dir2 format filesystems, it doesn't make sense to add the code to
v5 filesystems until all of the work is complete as there could be
additional considerations for the on disk changes.

We also noted that this feature should not be added to the kernel until
userspace code is available to support this feature.  Specifically,
xfs_repair needs to validate and if needed repair the the file type field.
Also, tests are needed to validate the new functionality.  While I
expect that you will provide this support for v5 superblock and dir3
filesystems, one of us at SGI will extend the support to v4 superblock
and dir2 filesystems.

Hi Geoffrey,

As much as the community admires your brave willingness to protect us from code that was entirely developed by Dave, that is not really how the upstream kernel works.

Dave is pretty much without equal in moving XFS along these days and this is a key feature that we are depending on.

Please don't try to create hurdles to other people getting work into upstream, that kind of thing will lead to a fork of the XFS code base and ultimately that will be harder for all of us.

It sounds like what you really should look at doing is to work inside of SGI to create a private, internal branch of the upstream code that you deliver in your product. Upstream code is all about innovation and new features, we don't let vendor specific, non-upstream branches become the place for hardening our code.

Best regards,


<Prev in Thread] Current Thread [Next in Thread>