xfs
[Top] [All Lists]

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V3

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V3
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Wed, 14 Aug 2013 15:48:03 -0500
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1376510872-9951-1-git-send-email-jbacik@xxxxxxxxxxxx>
References: <1376510872-9951-1-git-send-email-jbacik@xxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 08/14/2013 03:07 PM, Josef Bacik wrote:
We were allowing users to delete their default subvolume, which is problematic.
This test is a regression test to make sure we don't let that happen in the
future.  Thanks,

Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
---
V2->V3: remove comment and abstract out the subvolid logic as per Eric's
   suggestions
V1->V2: address the comments made by Eric Sandeen.

Thanks for the patch Josef, this has been committed.

--Rich

commit f3df3fab7d3870aab222512126b06668d7db5d71
Author: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date:   Wed Aug 14 20:07:52 2013 +0000

    xfstests: btrfs/009: regression test for subvol delete

We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the
    future.  Thanks,

    Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
    Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

    [rjohnston: renumbered test from 003 to 009]

<Prev in Thread] Current Thread [Next in Thread>