| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: Failure growing xfs with linux 3.10.5 |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Wed, 14 Aug 2013 11:51:08 -0500 |
| Cc: | Michael Maier <m1278468@xxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20130814062041.GB12779@dastard> |
| References: | <52073905.8010608@xxxxxxxxxxx> <5207D9C4.7020102@xxxxxxxxxxx> <52090C6C.6060604@xxxxxxxxxxx> <20130813000453.GQ12779@dastard> <520A5132.6090608@xxxxxxxxxxx> <20130814062041.GB12779@dastard> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 8/14/13 1:20 AM, Dave Chinner wrote: > Hence looks like we'll need some new xfs_repair functionality to fix > this. It might take me a little while to get you a fix - perhaps > someone else with a little bit of spare time could get it done > sooner than I can. Anyone? Pff, not like I have the time, but it also looks pretty trivial. secondary_sb_wack() only conditionally checks & zeroes unused space; making it unconditional is probably all it takes. I think it also needs to _not_ zero sb_bad_features2 as it does today, because that is supposed to be kept in sync w/ sb_features2. I have a patch I'll test; it'd be great to get a metadump from Michael to test it on his original failure case. -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Failure growing xfs with linux 3.10.5, Eric Sandeen |
|---|---|
| Next by Date: | Re: Purpose of the XFS list -- was: A short digression on FOSS (Re: understanding speculative preallocation), Emmanuel Florac |
| Previous by Thread: | Re: Failure growing xfs with linux 3.10.5, Eric Sandeen |
| Next by Thread: | I am Dave Dawes..., Dave Dawes |
| Indexes: | [Date] [Thread] [Top] [All Lists] |