xfs
[Top] [All Lists]

Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items

To: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Subject: Re: [PATCH 50/50] xfs: use reference counts to free clean buffer items
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 14 Aug 2013 16:41:21 +1000
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAEH94Lir_YKgCLntOWrmhVsntR_wdJ4QcvtYYO+xPiNzxPKHFg@xxxxxxxxxxxxxx>
References: <1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <1376304611-22994-51-git-send-email-david@xxxxxxxxxxxxx> <520A4AB7.1080207@xxxxxxx> <20130813214648.GC6023@dastard> <520AAC79.1030608@xxxxxxx> <20130814035738.GD6023@dastard> <CAEH94Lir_YKgCLntOWrmhVsntR_wdJ4QcvtYYO+xPiNzxPKHFg@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 14, 2013 at 12:12:36PM +0800, Zhi Yong Wu wrote:
> On Wed, Aug 14, 2013 at 11:57 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > On Tue, Aug 13, 2013 at 05:00:25PM -0500, Mark Tinguely wrote:
> >> On 08/13/13 16:46, Dave Chinner wrote:
> >> >On Tue, Aug 13, 2013 at 10:03:19AM -0500, Mark Tinguely wrote:
> >> >>On 08/12/13 05:50, Dave Chinner wrote:
> >> >>>From: Dave Chinner<dchinner@xxxxxxxxxx>
> >> >>>
> >> >>>When a transaction is cancelled and the buffer log item is clean in
> >>
> >> ...
> >>
> >> >>
> >> >>why is a clean buffer on the AIL? Racing with a completion handler?
> >> >
> >> >"clean" means that it wasn't dirtied in the transaction - it can be
> >> >in the AIL and holding a reference count that way.
> >>
> >> I am wondering because it should not have made it into the CIL if it
> >> was not dirtied in a transaction - at least according to the the log
> >> item descriptor flag at least.
> >
> > CIL != AIL. IOWs, the bli_refcount going to zero doesn't always
> By the way, can you explain what the difference is between CIL and AIL?

Documentation/filesystems/xfs-delayed-logging-design.txt

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>