xfs
[Top] [All Lists]

Re: [PATCH] _test_generic_punch: Extend $testfile's size to work with 64

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] _test_generic_punch: Extend $testfile's size to work with 64k block.
From: chandan <chandan@xxxxxxxxxxxxxxxxxx>
Date: Tue, 13 Aug 2013 21:28:06 +0530
Cc: xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, sekharan@xxxxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130812011155.GL12779@dastard>
References: <3326777.u9YeDIQiYF@xxxxxxxxxxxxxxxxxxxxx> <20130812011155.GL12779@dastard>
User-agent: KMail/4.10.5 (Linux/3.10.5-201.fc19.x86_64; KDE/4.10.5; x86_64; ; )
Hello Dave,

> So, to do this properly, I'd suggest that the code needs to scale
> the offset/size of the IO being done by the filesystem block size,
> not use a fixed size. Using a filter on the bmap output to handle
> the different block ranges will ensure everything works correctly
> from a golden output POV, except for one thing - the md5sum.
> 
Yes, we did try the approach of using variable block size and scaling
the offset values in the filter function. But we got stuck
working with md5sum (since we would need two sets of md5sums (with and
without '-k' option) per block size). As suggested, I will be
reposting the patch to use "_requires_le_4k_blocksize".

chandan

<Prev in Thread] Current Thread [Next in Thread>