xfs
[Top] [All Lists]

Re: [PATCH v3 1/2] xfstests: add fssum tool

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH v3 1/2] xfstests: add fssum tool
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Tue, 13 Aug 2013 11:28:22 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Jan Schmidt <list.xfs@xxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "sbehrens@xxxxxxxxxxxxxxxx" <sbehrens@xxxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1376407704; bh=awyl/sxTIAm4TPSZ3wy9uCGZGPyKvlV8D0joenloNsU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=by+nWHAH/5v5WL5bBX8E5KHcrZBDocSuGlwHqwg6lPnIsz1bZyGM2WlMYqevZjEFB 5Y3RVFH1rzapMmO4Z+G9KWrDNPD4A6GnDYCCxPOyiRrBOOmXC7oPCuYU+34EVOotcB rHE9jyjPUNFFFsopLmzYdvY5jjpzGlSS8VC1aIaY=
In-reply-to: <BB446B35-F3DA-462E-9E2C-9E4B780BC6B9@xxxxxxxxxxx>
References: <1375949833-1104-1-git-send-email-list.xfs@xxxxxxxxxxxxx> <1375949833-1104-2-git-send-email-list.xfs@xxxxxxxxxxxxx> <5203D827.3050909@xxxxxxxxxxx> <20130812011539.GM12779@dastard> <BB446B35-F3DA-462E-9E2C-9E4B780BC6B9@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
On Sun, Aug 11, 2013 at 09:54:41PM -0500, Eric Sandeen wrote:
> On Aug 11, 2013, at 8:15 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> 
> > On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote:
> >> On 8/8/13 3:17 AM, Jan Schmidt wrote:
> >>> SUBDIRS =
> >>> 
> >>> LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
> >>> 
> >>> +OPT_LDLIBS = -lssl -lcrypto
> >> 
> >> Hm, new deps.  I guess it's not a huge problem, these should always
> >> be available, right?
> > 
> > Please, let's keep crypto out of xfstests if we can. That's just
> > going to add a nightmare of US export compliance garbage to any
> > distro that wants to package and ship this....
> > 
> It's ssl that's (optionally) required for check summing I believe.  But it's 
> optional if done properly...
> 

It doesn't build without -lcrypto for me, so either we have an external
dependancy (which I'm fine with), or we add it to xfstests (which is what you
wanted).  Does a config option alleviate your concerns?  And I it's just linking
it in at build time, I don't think we have to work about export compliance as
long as we aren't shipping actual crytpo stuff right?  Anybody who is going to
be running this stuff is going to have libssl installed, which installs
libcrypto (at least on my box) so I don't think it's a huge deal to have us
linking it.  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>