Re: [PATCH 44/50] xfs: Reduce allocations during CIL insertion

[Mark Tinguely <tinguely@xxxxxxx>]

On 08/12/13 05:50, Dave Chinner wrote:
> From: Dave Chinner<dchinner@xxxxxxxxxx>
>
> Now that we have the size of the object before the formatting pass
> is called, we can allocation the log vector and it's buffer in a
> single allocation rather than two separate allocations.
>
> Store the size of the allocated buffer in the log vector so that
> we potentially avoid allocation for future modifications of the
> object.
>
> While touching this code, remove the IOP_FORMAT definition.
>
> Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> ---
...

>                 /* Skip items which aren't dirty in this transaction. */
> @@ -150,48 +178,39 @@ xlog_cil_prepare_log_vecs(
...

> +               lv->lv_buf_len = xlog_cil_lv_item_format(lip, lv);
Looks good

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>