xfs
[Top] [All Lists]

Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 13 Aug 2013 15:51:37 +0800
Cc: kbuild test robot <fengguang.wu@xxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130813065355.GB6023@dastard>
References: <5209C4D0.5050203@xxxxxxxxxx> <20130813065355.GB6023@dastard>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1
On 08/13/2013 02:53 PM, Dave Chinner wrote:

> On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> Replace roundup() with roundup_64() as we calculate min_logblks
>> with 64-bit divisions.  Hence, call roundup() will cause the
>> following error while compiling a 32-bit kernel:
>>
>> fs/built-in.o: In function `xfs_log_calc_minimum_size':
>> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3'
>>
>> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
>> Cc: Dave Chinner <dchinner@xxxxxxxxxx>
>> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> You beat me to it, Jeff. I got an email from Fengguang's build farm,
> too. :)

Hi Dave,

I'm on a longer vacations these days(until next week).  I have asked
my friend for help checking our mailing list to watch if there's any
email for me before the leaving, so I got his phone call this morning
for this bug. :)

> 
> Your fix looks good.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Thanks for your quick review!

-Jeff

<Prev in Thread] Current Thread [Next in Thread>