xfs
[Top] [All Lists]

Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: call roundup_64() to calculate the min_logblks
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 13 Aug 2013 16:53:55 +1000
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, kbuild test robot <fengguang.wu@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5209C4D0.5050203@xxxxxxxxxx>
References: <5209C4D0.5050203@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Replace roundup() with roundup_64() as we calculate min_logblks
> with 64-bit divisions.  Hence, call roundup() will cause the
> following error while compiling a 32-bit kernel:
> 
> fs/built-in.o: In function `xfs_log_calc_minimum_size':
> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3'
> 
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Cc: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

You beat me to it, Jeff. I got an email from Fengguang's build farm,
too. :)

Your fix looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>