On Thu, Aug 08, 2013 at 05:02:24PM -0500, Ben Myers wrote:
> On Thu, Aug 08, 2013 at 04:06:01PM -0500, Ben Myers wrote:
> > On Tue, Aug 06, 2013 at 04:41:54PM -0500, Ben Myers wrote:
> > > On Fri, Jun 07, 2013 at 10:25:23AM +1000, Dave Chinner wrote:
> > > > Hi folks,
> > > >
> > > > This is the latest update of the series of patches tht introduces
> > > > CRC support into xfsprogs. Of note, for CRC enabled filesystems;
> > > >
> > > > - write support for xfs-db is disabled
> > > > - obfuscation for metadump is disabled
> > > > - xfs_check does nothing ("always succeed") so that xfstests
> > > > can run without needing this
> > > > - all structures shoul dbe supported for printing in xfs_db
> > > > - xfs_repair should be able to fully validate the structure
> > > > of a CRC enabled filesystem.
> > > > - xfs_repair still ignores CRC validation errors when
> > > > reading metadata
> > > > - mkfs.xfs enforces limitations on the format of CRC enabled
> > > > filesystems (inode size, attr format, projid32bit, etc).
> > > > - whenever a v5 superblock is parsed on read by any utility,
> > > > it outputs a wanring about it being an experimental
> > > > format.
> > > >
> > > > Bug reports, patches, comments, reviews, etc all welcome.
> > >
> > > Pulled in 1-48 of the first series and 1-12 of the second.
> >
> > Here is a patch series that addresses some of my outstanding concerns from
> > review. Some may be already fixed in the 2nd series, I'm not sure. Eric
> > also
> > mentioned that he put the updated branch through coverity and found some
> > defects. There may be some overlap there too.
> >
> > Some of these are just reminders for myself to make sure certain items are
> > addressed eventually. Sorry for the noise.
>
> I'll stop at 9. The rest of them are notes to myself:
>
> * xfs_db write support needs to be done
Dependent on being able to write crcs. needs xfs_db to be converted
to libxfs based IO.
> * xfs_metadump obfuscation needs to be done
dependent on the same thing as xfs_db write support.
> * xfs_mdrestore needs to work
Shoul dwork if xfs_metadump works properly.
> * xfs_check needs work
Probably not. It's deprecated.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|