xfs
[Top] [All Lists]

***** SUSPECTED SPAM ***** Re: [PATCH 3/14] xfsprogs: pull in the rest

To: Ben Myers <bpm@xxxxxxx>
Subject: ***** SUSPECTED SPAM ***** Re: [PATCH 3/14] xfsprogs: pull in the rest of 93848a999cf
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 12 Aug 2013 09:26:51 +1000
Cc: xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Importance: Low
In-reply-to: <20130808211352.GQ3111@xxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <20130806214154.GM3111@xxxxxxx> <20130808210600.GN3111@xxxxxxx> <20130808211352.GQ3111@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 08, 2013 at 04:13:52PM -0500, Ben Myers wrote:
> XXX Maybe I missed some more...
> 
> ---
>  libxfs/xfs_ialloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/libxfs/xfs_ialloc.c
> ===================================================================
> --- a/libxfs/xfs_ialloc.c     2013-08-06 11:25:54.400817879 -0500
> +++ b/libxfs/xfs_ialloc.c     2013-08-06 11:26:32.420897946 -0500
> @@ -204,7 +204,7 @@ xfs_ialloc_inode_init(
>                *      individual transactions causing a lot of log traffic.
>                */
>               fbuf->b_ops = &xfs_inode_buf_ops;
> -             xfs_buf_zero(fbuf, 0, ninodes << mp->m_sb.sb_inodelog);
> +             xfs_buf_zero(fbuf, 0, BBTOB(fbuf->b_length));
>               for (i = 0; i < ninodes; i++) {
>                       int     ioffset = i << mp->m_sb.sb_inodelog;
>                       uint    isize = xfs_dinode_size(version);

It's fixed in the second series of patches, along with all the other
little differences between the kernel and userspace. There's no
point in trying to fix them one by one here, because untill it's
easy to diff the files with the kernel code these sorts of issues
will be easily missed.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>