xfs
[Top] [All Lists]

***** SUSPECTED SPAM ***** Re: [PATCH 5/14] xfsprogs: sync commit f5f3d

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: ***** SUSPECTED SPAM ***** Re: [PATCH 5/14] xfsprogs: sync commit f5f3d9b016 completely
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 12 Aug 2013 09:23:42 +1000
Cc: Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Importance: Low
In-reply-to: <52041617.1020508@xxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <20130806214154.GM3111@xxxxxxx> <20130808210600.GN3111@xxxxxxx> <20130808212012.GS3111@xxxxxxx> <52041617.1020508@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 08, 2013 at 05:05:11PM -0500, Eric Sandeen wrote:
> On 8/8/13 4:20 PM, Ben Myers wrote:
> > TODO
> > 
> > ---
> >  include/xfs_dir2_format.h |    2 +-
> >  libxfs/xfs_dir2_data.c    |    2 ++
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > Index: b/include/xfs_dir2_format.h
> > ===================================================================
> > --- a/include/xfs_dir2_format.h     2013-08-06 12:52:58.830818621 -0500
> > +++ b/include/xfs_dir2_format.h     2013-08-06 12:53:38.550877679 -0500
> > @@ -247,7 +247,7 @@ typedef struct xfs_dir2_data_free {
> >   */
> >  typedef struct xfs_dir2_data_hdr {
> >     __be32                  magic;          /* XFS_DIR2_DATA_MAGIC or */
> > -   /* XFS_DIR2_BLOCK_MAGIC */
> > +                                           /* XFS_DIR2_BLOCK_MAGIC */
> >     xfs_dir2_data_free_t    bestfree[XFS_DIR2_DATA_FD_COUNT];
> >  } xfs_dir2_data_hdr_t;
> >  
> > Index: b/libxfs/xfs_dir2_data.c
> > ===================================================================
> > --- a/libxfs/xfs_dir2_data.c        2013-08-06 12:54:17.540817693 -0500
> > +++ b/libxfs/xfs_dir2_data.c        2013-08-06 12:55:10.460877745 -0500
> > @@ -54,6 +54,7 @@ __xfs_dir2_data_check(
> >     p = (char *)xfs_dir3_data_entry_p(hdr);
> >  
> >     switch (be32_to_cpu(hdr->magic)) {
> > +           /* XXX bpm endian switch does not match commit */
> 
> in userspace, for some reason, doing it the "kernel way"
> 
> (i.e. 
> 
> switch (hdr->magic) {
> case cpu_to_be32(XFS_DIR2_BLOCK_MAGIC):
> 
>  ...)
> 
> yields:
> 
> xfs_dir2_data.c:57: error: case label does not reduce to an integer constant

Right, and as I've already pointed out previously it's fixed in the
second series of patches by this:

[PATCH 06/49] libxfs: fix byte swapping on constants

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>