| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [v2 PATCH 8/14] xfsprogs: fix issues with e0607266f23 |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Fri, 9 Aug 2013 09:00:57 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <52042B04.7070707@xxxxxxxxxxx> |
| References: | <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <20130806214154.GM3111@xxxxxxx> <20130808210600.GN3111@xxxxxxx> <20130808215330.GV3111@xxxxxxx> <52041686.4040703@xxxxxxxxxxx> <5204183E.2000902@xxxxxxxxxxx> <20130808222821.GY3111@xxxxxxx> <52042937.6050702@xxxxxxxxxxx> <52042B04.7070707@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Thu, Aug 08, 2013 at 06:34:28PM -0500, Eric Sandeen wrote: > On 8/8/13 6:26 PM, Eric Sandeen wrote: > > On 8/8/13 5:28 PM, Ben Myers wrote: > >> * remove unused uuid unparse in xfs_agf_verify > >> * fix an unnecessary loop in clear_dinode_core > > > > These should be 2 commits (they do 2 different things), > > with properly descriptive summaries & changelogs. > > > > For the 2nd, it's not an unnecessary loop, it's a memory > > corruptor; that should be noted in the changelog. > > > > TBH I've only reviewed the latter, I need to look at > > the first. > > Yup the first is fine too, but should be a separate commit. Sounds good, thanks Eric. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] mkfs.xfs: fix protofile name create block reservation, Mark Tinguely |
|---|---|
| Next by Date: | prjquota not updating used blocks, Weber, Charles (NIH/NIA/IRP) [C] |
| Previous by Thread: | Re: [v2 PATCH 8/14] xfsprogs: fix issues with e0607266f23, Eric Sandeen |
| Next by Thread: | [PATCH 9] xfsprogs: issues with a24374f41c9, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |