[Top] [All Lists]

Re: [PATCH v3] xfsprogs/io: add readdir command

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v3] xfsprogs/io: add readdir command
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 09 Aug 2013 08:21:11 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1376051546-31578-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1376051546-31578-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/09/13 07:32, Brian Foster wrote:
readdir reads the directory entries from an open directory from
the provided offset (or 0 if not specified). On completion,
readdir prints summary information regarding the number of
operations and bytes transferred. Options are available to specify
the starting offset, length and verbose mode to dump directory
entry information.

Signed-off-by: Brian Foster<bfoster@xxxxxxxxxx>

- dup() file->fd and add corresponding closedir() (mark).
- add readdir section to xfs_io manpage (mark).

- Convert from getdents to readdir.
- Use configure mechanism for libc readdir() availability (zab).
- Add extra dirent fields to verbose output (zab).

Thank-you, looks great. We can get it in right away.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>