xfs
[Top] [All Lists]

Re: [v2 PATCH 8/14] xfsprogs: fix issues with e0607266f23

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [v2 PATCH 8/14] xfsprogs: fix issues with e0607266f23
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 08 Aug 2013 18:34:28 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52042937.6050702@xxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <20130806214154.GM3111@xxxxxxx> <20130808210600.GN3111@xxxxxxx> <20130808215330.GV3111@xxxxxxx> <52041686.4040703@xxxxxxxxxxx> <5204183E.2000902@xxxxxxxxxxx> <20130808222821.GY3111@xxxxxxx> <52042937.6050702@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 8/8/13 6:26 PM, Eric Sandeen wrote:
> On 8/8/13 5:28 PM, Ben Myers wrote:
>> * remove unused uuid unparse in xfs_agf_verify
>> * fix an unnecessary loop in clear_dinode_core
> 
> These should be 2 commits (they do 2 different things),
> with properly descriptive summaries & changelogs.
> 
> For the 2nd, it's not an unnecessary loop, it's a memory
> corruptor; that should be noted in the changelog.
> 
> TBH I've only reviewed the latter, I need to look at
> the first.

Yup the first is fine too, but should be a separate commit.

Thanks,
-Eric

> -Eric
> 
> 

<Prev in Thread] Current Thread [Next in Thread>