| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 1/14] libxfs: don't verify bmbt reads twice |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Thu, 8 Aug 2013 16:07:32 -0500 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20130808210600.GN3111@xxxxxxx> |
| References: | <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <20130806214154.GM3111@xxxxxxx> <20130808210600.GN3111@xxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
xfs_bmbt_read_verify is calling xfs_bmbt_verify twice in a row. commit
ee1a47ab0e in the kernel removed the first xfs_bmbt_verify but this was
not carried over when it was implemented in userspace.
Signed-off-by: Ben Myers <bpm@xxxxxxx>
---
libxfs/xfs_bmap_btree.c | 2 --
1 file changed, 2 deletions(-)
Index: b/libxfs/xfs_bmap_btree.c
===================================================================
--- a/libxfs/xfs_bmap_btree.c 2013-08-08 15:56:12.960817743 -0500
+++ b/libxfs/xfs_bmap_btree.c 2013-08-08 15:56:14.150857067 -0500
@@ -759,7 +759,6 @@ static void
xfs_bmbt_read_verify(
struct xfs_buf *bp)
{
- xfs_bmbt_verify(bp);
if (!(xfs_btree_lblock_verify_crc(bp) &&
xfs_bmbt_verify(bp))) {
trace_xfs_btree_corrupt(bp, _RET_IP_);
@@ -767,7 +766,6 @@ xfs_bmbt_read_verify(
bp->b_target->bt_mount, bp->b_addr);
xfs_buf_ioerror(bp, EFSCORRUPTED);
}
-
}
static void
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 0/14] xfsprogs: various issues from review, Ben Myers |
|---|---|
| Next by Date: | [PATCH 2/14] xfsprogs: XFS_AGF_NUM_BITS should be 13, Ben Myers |
| Previous by Thread: | [PATCH 0/14] xfsprogs: various issues from review, Ben Myers |
| Next by Thread: | [PATCH 2/14] xfsprogs: XFS_AGF_NUM_BITS should be 13, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |