xfs
[Top] [All Lists]

Re: [PATCH v2] xfsprogs/io: add readdir command

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfsprogs/io: add readdir command
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 08 Aug 2013 09:05:43 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374669868-14075-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1374669868-14075-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/24/13 07:44, Brian Foster wrote:
readdir reads the directory entries from an open directory from
the provided offset (or 0 if not specified). On completion,
readdir prints summary information regarding the number of
operations and bytes transferred. Options are available to specify
the starting offset, length and verbose mode to dump directory
entry information.

Signed-off-by: Brian Foster<bfoster@xxxxxxxxxx>
---

v2:
- Convert from getdents to readdir.
- Use configure mechanism for libc readdir() availability (zab).
- Add extra dirent fields to verbose output (zab).


Just started to look at this.

Shouldn't there be a "closedir(dir);" to close the directory stream and release the directory structure?

Could we get a little info for the xfs_io man page?

Looks like a nice feature.

Thanks.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>