xfs
[Top] [All Lists]

Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 07/12] xfs: fix the comment of xfs_iroot_realloc()
From: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Date: Wed, 7 Aug 2013 22:41:53 +0800
Cc: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=vGTbK+AQ9dnbnkkWUw/fSOn+FJ7cLg9+arX97ChVQ98=; b=N2dIzdDZBFlWGuevKUVYyzrGqBAEAwh28qLkHswDKc30WoKHOAO+w8FEJqGB2d2Gko FpcBbqMrGt+O6t7m8ozDALsrCo2Cvs6Ifyua3bpcZU7BiXEbhE4Pk5T9gomBcbldcaBy WhmTeTw1G74soUqiOVFvgQ7LGv3pwqVQWtSiYWAce7ERl/b43nPTJnoGtNLrMkIkCovP AXWL1bVTU9BgeZveKFnuI6ifgtS9EgWQaoa3nyv/jEescpo7vnu+ppQdcA/UGoMFsVQE dNEKZdsWmyy9tH2VEMVL2b/pJ2ME97o2B/E/dqqLRtt640fnvbPeqMfxJq51O5cllKdl Sruw==
In-reply-to: <520259EA.1050801@xxxxxxx>
References: <1375870269-13157-1-git-send-email-zwu.kernel@xxxxxxxxx> <1375870269-13157-8-git-send-email-zwu.kernel@xxxxxxxxx> <52024BB4.5060109@xxxxxxx> <CAEH94LixsQOOGpcuyMNOxi+_FscL5sE8Q2KoPYgdf0JESnPaSA@xxxxxxxxxxxxxx> <520259EA.1050801@xxxxxxx>
On Wed, Aug 7, 2013 at 10:30 PM, Mark Tinguely <tinguely@xxxxxxx> wrote:
> On 08/07/13 09:01, Zhi Yong Wu wrote:
>>
>> On Wed, Aug 7, 2013 at 9:29 PM, Mark Tinguely<tinguely@xxxxxxx>  wrote:
>>>
>>> On 08/07/13 05:11, zwu.kernel@xxxxxxxxx wrote:
>>>>
>>>>
>>>> From: Zhi Yong Wu<wuzhy@xxxxxxxxxxxxxxxxxx>
>>>>
>>>> Signed-off-by: Zhi Yong Wu<wuzhy@xxxxxxxxxxxxxxxxxx>
>>>> ---
>>>>    fs/xfs/xfs_inode.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
>>>> index bb262c2..ccca9cd 100644
>>>> --- a/fs/xfs/xfs_inode.c
>>>> +++ b/fs/xfs/xfs_inode.c
>>>> @@ -2103,7 +2103,7 @@ xfs_ifree(
>>>>     *
>>>>     * The caller must not request to add more records than would fit in
>>>>     * the on-disk inode root.  If the if_broot is currently NULL, then
>>>> - * if we adding records one will be allocated.  The caller must also
>>>> + * if we are adding records, one will be allocated.  The caller must
>>>> also
>>>>     * not request that the number of records go below zero, although
>>>>     * it can go to zero.
>>>>     *
>>>
>>>
>>>
>>>
>>> Change this to xfs_inode_fork.c and the series will apply on top of
>>> Dave's
>>> "current patch queue for Linux 3.12":
>>
>> Do you mean that you have done this or i need to do this? If i need to do
>> this,
>> can you let me know where i can get xfs git repo which has applied
>> Dave's patchset?
>>
>>>
>>>    http://oss.sgi.com/archives/xfs/2013-07/msg00411.html
>
>
>
> If approved, we can make the change on commit.
Please feel free to do it, thanks a lot.
>
> The patches look okay to me.
>
> --Mark.
>



-- 
Regards,

Zhi Yong Wu

<Prev in Thread] Current Thread [Next in Thread>