xfs
[Top] [All Lists]

Re: [PATCH v2 1/2] xfstests: add fssum tool

To: Jan Schmidt <list.xfs@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 1/2] xfstests: add fssum tool
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Tue, 6 Aug 2013 16:42:25 -0400
Cc: <xfs@xxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>, <sbehrens@xxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1375821747; bh=UUW516zqprQcAnnoSbJKOl/LGB41kh4i4eMR+dYiy6E=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=G97opZ8BH+vju4z+Fj+w6Li+U3f8/XScoKMj+wavbxgRMLXhm5b6d5owDIlto0HhH Hxc+sfVHbRJGMMYI5gOw11DpoemBY9ww8ipDB4h8Rg9QHMfLvYwsQWQrCTh8hkE2nz qNfDv6awtdyXWXRZ199GHS5LCGtJTCt7T8FtuOWU=
In-reply-to: <1374678449-21780-2-git-send-email-list.xfs@xxxxxxxxxxxxx>
References: <1374678449-21780-1-git-send-email-list.xfs@xxxxxxxxxxxxx> <1374678449-21780-2-git-send-email-list.xfs@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
On Wed, Jul 24, 2013 at 05:07:28PM +0200, Jan Schmidt wrote:
> fssum is a tool to build a recursive checksum for a file system. The home
> repository of fssum is
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/arne/far-progs.git
> 
> It is added as an optional target, because it depends on glibc >= 2.15 for
> SEEK_HOLE / SEEK_DATA. The test to be added using fssum will just be skipped
> if fssum wasn't built.
> 
> Signed-off-by: Jan Schmidt <list.xfs@xxxxxxxxxxxxx>
> ---
>  .gitignore    |    1 +
>  common/config |    2 +
>  src/Makefile  |   11 +-
>  src/fssum.c   |  819 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 832 insertions(+), 1 deletions(-)
>  create mode 100644 src/fssum.c
> 
> diff --git a/.gitignore b/.gitignore
> index 11594aa..c2fc6e3 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -45,6 +45,7 @@
>  /src/fill
>  /src/fill2
>  /src/fs_perms
> +/src/fssum
>  /src/fstest
>  /src/fsync-tester
>  /src/ftrunc
> diff --git a/common/config b/common/config
> index 67c1498..c8bee29 100644
> --- a/common/config
> +++ b/common/config
> @@ -146,6 +146,8 @@ export SED_PROG="`set_prog_path sed`"
>  export BC_PROG="`set_prog_path bc`"
>  [ "$BC_PROG" = "" ] && _fatal "bc not found"
>  
> +export FSSUM_PROG="`set_prog_path fssum $here/src/fssum`"
> +
>  export PS_ALL_FLAGS="-ef"
>  
>  export DF_PROG="`set_prog_path df`"
> diff --git a/src/Makefile b/src/Makefile
> index cc679e8..a840669 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -20,10 +20,14 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize 
> preallo_rw_pattern_reader \
>       stale_handle pwrite_mmap_blocked t_dir_offset2 seek_sanity_test \
>       seek_copy_test t_readdir_1 t_readdir_2 fsync-tester
>  
> +OPT_TARGETS = fssum
> +
>  SUBDIRS =
>  
>  LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
>  
> +OPT_LDLIBS = -lssl
> +

I had to add -lcrypto here for this to build, and I checked my copy of far-progs
and it looks like I'm not just crazy that you guys actually do -lcrypto in
far-progs as well, so looks like you missed it.  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2 1/2] xfstests: add fssum tool, Josef Bacik <=