xfs
[Top] [All Lists]

Re: [PATCH 44/49] xfs: refactor xfs_trans_reserve() interface

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 44/49] xfs: refactor xfs_trans_reserve() interface
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 06 Aug 2013 14:12:59 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374216324-8781-45-git-send-email-david@xxxxxxxxxxxxx>
References: <1374216324-8781-1-git-send-email-david@xxxxxxxxxxxxx> <1374216324-8781-45-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:45, Dave Chinner wrote:
From: Jie Liu<jeff.liu@xxxxxxxxxx>

With the new xfs_trans_res structure has been introduced, the log
reservation size, log count as well as log flags are pre-initialized
at mount time.  So it's time to refine xfs_trans_reserve() interface
to be more neat.

Also, introduce a new helper M_RES() to return a pointer to the
mp->m_resv structure to simplify the input.

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

user equivalent of the for Linux 3.12 kernel patch 38/49
plus modifying the calls to libxfs_trans_reserve() in
xfsprogs.

Still think you should remove the M_RES(mp) define.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 44/49] xfs: refactor xfs_trans_reserve() interface, Mark Tinguely <=