xfs
[Top] [All Lists]

Re: [PATCH 04/48] xfsprogs: add crc format chagnes to ag headers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/48] xfsprogs: add crc format chagnes to ag headers
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 6 Aug 2013 10:42:18 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130723185228.GJ3111@xxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-5-git-send-email-david@xxxxxxxxxxxxx> <20130723185228.GJ3111@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jul 23, 2013 at 01:52:28PM -0500, Ben Myers wrote:
> On Fri, Jun 07, 2013 at 10:25:27AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> This corresponds with commits 4e0e6040c405, 77c95bba013, and 983d09ffe3.
> 
> > diff --git a/include/xfs_ag.h b/include/xfs_ag.h
> > index f2aeedb..1e0fa34 100644
> > --- a/include/xfs_ag.h
> > +++ b/include/xfs_ag.h
> 
> ...
> 
> > @@ -83,6 +101,7 @@ typedef struct xfs_agf {
> >  #define    XFS_AGF_FREEBLKS        0x00000200
> >  #define    XFS_AGF_LONGEST         0x00000400
> >  #define    XFS_AGF_BTREEBLKS       0x00000800
> > +#define    XFS_AGF_UUID            0x00001000
> >  #define    XFS_AGF_NUM_BITS        12
>                                       ^^
> 
>                                       Should be 13 now.

Looks like this synced over in patch 33 of the subsequent series.

From: Ben Myers <bpm@xxxxxxx>
Subject: xfsprogs XFS_AGF_NUM_BITS should be 13

commit 4e0e6040c4052aff15a494ac05778f4086d24c33 changed XFS_AGF_NUM_BITS
to be 13, however when this commit was applied to userspace the change
was not pulled over.

Signed-off-by: Ben Myers <bpm@xxxxxxx>

---
 include/xfs_ag.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/include/xfs_ag.h
===================================================================
--- a/include/xfs_ag.h  2013-08-06 10:41:02.850817460 -0500
+++ b/include/xfs_ag.h  2013-08-06 10:41:07.360857099 -0500
@@ -102,7 +102,7 @@ typedef struct xfs_agf {
 #define        XFS_AGF_LONGEST         0x00000400
 #define        XFS_AGF_BTREEBLKS       0x00000800
 #define        XFS_AGF_UUID            0x00001000
-#define        XFS_AGF_NUM_BITS        12
+#define        XFS_AGF_NUM_BITS        13
 #define        XFS_AGF_ALL_BITS        ((1 << XFS_AGF_NUM_BITS) - 1)
 
 #define XFS_AGF_FLAGS \

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 04/48] xfsprogs: add crc format chagnes to ag headers, Ben Myers <=