[Top] [All Lists]

Re: [PATCH 10/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_comp

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_compact
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 5 Aug 2013 17:16:03 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370607901-11538-11-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:24:59PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> xfs_attr3_leaf_compact() uses a temporary buffer for compacting the
> the entries in a leaf. It copies the the original buffer into the
> temporary buffer, then zeros the original buffer completely. It then
> copies the entries back into the original buffer.  However, the
> original buffer has not been correctly initialised, and so the
> movement of the entries goes horribly wrong.
> Make sure the zeroed destination buffer is fully initialised, and
> once we've set up the destination incore header appropriately, write
> is back to the buffer before starting to move entries around.
> While debugging this, the _d/_s prefixes weren't sufficient to
> remind me what buffer was what, so rename then all _src/_dst.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Goes with commit d4c712bcf26a25c2b67c90e44e0b74c7993b5334

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 10/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_compact, Ben Myers <=