xfs
[Top] [All Lists]

Re: [PATCH 09/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_unba

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_unbalance
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 5 Aug 2013 17:12:51 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370607901-11538-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:24:58PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_attr3_leaf_unbalance() uses a temporary buffer for recombining
> the entries in two leaves when the destination leaf requires
> compaction. The temporary buffer ends up being copied back over the
> original destination buffer, so the header in the temporary buffer
> needs to contain all the information that is in the destination
> buffer.
> 
> To make sure the temporary buffer is fully initialised, once we've
> set up the temporary incore header appropriately, write is back to
> the temporary buffer before starting to move entries around.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Goes with commit 8517de2a81da830f5d90da66b4799f4040c76dc9

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 09/12] xfs: fully initialise temp leaf in xfs_attr3_leaf_unbalance, Ben Myers <=