xfs
[Top] [All Lists]

Re: [PATCH 08/12] xfs: correctly map remote attr buffers during removal

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/12] xfs: correctly map remote attr buffers during removal
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 5 Aug 2013 17:07:04 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370607901-11538-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:24:57PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> If we don't map the buffers correctly (same as for get/set
> operations) then the incore buffer lookup will fail. If a block
> number matches but a length is wrong, then debug kernels will ASSERT
> fail in _xfs_buf_find() due to the length mismatch. Ensure that we
> map the buffers correctly by basing the length of the buffer on the
> attribute data length rather than the remote block count.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Goes with commit 6863ef8449f1908c19f43db572e4474f24a1e9da

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 08/12] xfs: correctly map remote attr buffers during removal, Ben Myers <=