xfs
[Top] [All Lists]

Re: [PATCH 05/12] xfs: remote attribute allocation may be contiguous

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/12] xfs: remote attribute allocation may be contiguous
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 5 Aug 2013 16:54:35 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370607901-11538-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-1-git-send-email-david@xxxxxxxxxxxxx> <1370607901-11538-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:24:54PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When CRCs are enabled, there may be multiple allocations made if the
> headers cause a length overflow. This, however, does not mean that
> the number of headers required increases, as the second and
> subsequent extents may be contiguous with the previous extent. Hence
> when we map the extents to write the attribute data, we may end up
> with less extents than allocations made. Hence the assertion that we
> consume th enumber of headers we calculated in the allocation loop
> is incorrect and needs to be removed.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Goes with commit 90253cf142469a40f89f989904abf0a1e500e1a6

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 05/12] xfs: remote attribute allocation may be contiguous, Ben Myers <=