xfs
[Top] [All Lists]

Re: [PATCH 32/48] xfs_db: convert directory parsing to use libxfs struct

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 32/48] xfs_db: convert directory parsing to use libxfs structure
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 5 Aug 2013 09:52:03 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-33-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-33-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:55AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db rolls it's own "opaque" directory types for the different
> block formats. All it cares about is where the headers end and the
> data starts, and none of the other details in the structures. Rather
> than duplicate this for the dir3 format, we already have perfectly
> good headers and abstraction functions for finding this information
> in libxfs.  Using these means that the dir2 code used for printing
> fields, metadump and check need to be modified to use libxfs
> definitions.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 32/48] xfs_db: convert directory parsing to use libxfs structure, Ben Myers <=