xfs
[Top] [All Lists]

Re: [PATCH 06/10 v2] xfstests: Allow to specify RESULT_BASE directory

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 06/10 v2] xfstests: Allow to specify RESULT_BASE directory
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Fri, 02 Aug 2013 18:51:52 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1373539085-8577-7-git-send-email-lczerner@xxxxxxxxxx>
Organization: IBM
References: <1373539085-8577-1-git-send-email-lczerner@xxxxxxxxxx> <1373539085-8577-7-git-send-email-lczerner@xxxxxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
On Thu, 2013-07-11 at 12:38 +0200, Lukas Czerner wrote:
> This commit adds the possibility to specify RESULT_BASE directory from
> the config file, or with environment variable. The default remains the
> same "$here/results/".
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Reviewed-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

> ---
>  check         | 1 -
>  common/config | 5 +++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index dc972d7..428eba1 100755
> --- a/check
> +++ b/check
> @@ -66,7 +66,6 @@ export FSTYP
>  SUPPORTED_TESTS="[0-9][0-9][0-9] [0-9][0-9][0-9][0-9]"
>  SRC_GROUPS="generic shared"
>  export SRC_DIR="tests"
> -export RESULT_BASE=${RESULT_BASE:="$here/results"}
> 
>  usage()
>  {
> diff --git a/common/config b/common/config
> index 34c99e1..39dd469 100644
> --- a/common/config
> +++ b/common/config
> @@ -230,6 +230,11 @@ if [ -f "$HOST_OPTIONS" ]; then
>  fi
> 
>  get_next_config() {
> +     # set default RESULT_BASE
> +     if [ -z "$RESULT_BASE" ]; then
> +             export RESULT_BASE="$here/results/"
> +     fi
> +
>       #  Mandatory Config values.
>       MC=""
>       [ -z "$EMAIL" ]          && MC="$MC EMAIL"


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 06/10 v2] xfstests: Allow to specify RESULT_BASE directory, Chandra Seetharaman <=