xfs
[Top] [All Lists]

Re: [PATCH 01/10 v2] xfstests: Run all tests when nothing is specified

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 01/10 v2] xfstests: Run all tests when nothing is specified
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Fri, 02 Aug 2013 18:48:19 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1373539085-8577-2-git-send-email-lczerner@xxxxxxxxxx>
Organization: IBM
References: <1373539085-8577-1-git-send-email-lczerner@xxxxxxxxxx> <1373539085-8577-2-git-send-email-lczerner@xxxxxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
On Thu, 2013-07-11 at 12:37 +0200, Lukas Czerner wrote:

small nits. Otherwise,

Reviewed-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>

> Currently when no tests or test groups is specified xfstests will
s/is/are/

> silently test nothing. Interestingly enough when test groups to exclude
> is specified the rest of the tests will be run.
s/is/are/

> 
> This commit changes that to run all possible tests (for a given file
> system) when no specific tests has been specified. This matches the old
> xfstests behaviour.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> ---
>  check | 6 +++---
>  group | 5 -----
>  2 files changed, 3 insertions(+), 8 deletions(-)
>  delete mode 100644 group
> 
> diff --git a/check b/check
> index ff8fbcf..71b179b 100755
> --- a/check
> +++ b/check
> @@ -115,7 +115,7 @@ get_all_tests()
>       for d in $SRC_GROUPS $FSTYP; do
>               ls $SRC_DIR/$d/* | \
>                       grep -v "\..*" | \
> -                     grep -v group >> $tmp.list 2>/dev/null
> +                     grep -v "group\|Makefile" >> $tmp.list 2>/dev/null
>       done
>  }
> 
> @@ -263,8 +263,8 @@ elif $have_test_arg; then
>       # had test numbers, but none in group file ... do nothing
>       touch $tmp.list
>  else
> -     # no test numbers, do everything from group file
> -     sed -n -e '/^[0-9][0-9][0-9]*/s/[       ].*//p' <group >$tmp.list
> +     # no test numbers, do everything
> +     get_all_tests
>  fi
> 
>  # sort the list of tests into numeric order
> diff --git a/group b/group
> deleted file mode 100644
> index 4e01f0c..0000000
> --- a/group
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# QA groups control file
> -# Defines test groups and nominal group owners
> -# - do not start group names with a digit
> -# - comment line before each group is "new" description
> -#


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 01/10 v2] xfstests: Run all tests when nothing is specified, Chandra Seetharaman <=