xfs
[Top] [All Lists]

Re: [PATCH 14/49] xfs: remove local fork format handling from xfs_bmapi_

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 14/49] xfs: remove local fork format handling from xfs_bmapi_write()
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 02 Aug 2013 16:42:45 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374216324-8781-15-git-send-email-david@xxxxxxxxxxxxx>
References: <1374216324-8781-1-git-send-email-david@xxxxxxxxxxxxx> <1374216324-8781-15-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:44, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The conversion from local format to extent format requires
interpretation of the data in the fork being converted, so it cannot
be done in a generic way. It is up to the caller to convert the fork
format to extent format before calling into xfs_bmapi_write() so
format conversion can be done correctly.

The code in xfs_bmapi_write() to convert the format is used
implicitly by the attribute and directory code, but they
specifically zero the fork size so that the conversion does not do
any allocation or manipulation. Move this conversion into the
shortform to leaf functions for the dir/attr code so the conversions
are explicitly controlled by all callers.

Now we can remove the conversion code in xfs_bmapi_write.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

same as kernel commit f3508bcd which I reviewed on June 27.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 14/49] xfs: remove local fork format handling from xfs_bmapi_write(), Mark Tinguely <=