[Top] [All Lists]

Re: [PATCH 13/49] libxfs: fix compile warnings

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 13/49] libxfs: fix compile warnings
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 02 Aug 2013 16:13:04 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374216324-8781-14-git-send-email-david@xxxxxxxxxxxxx>
References: <1374216324-8781-1-git-send-email-david@xxxxxxxxxxxxx> <1374216324-8781-14-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:44, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Some of the code shared with userspace causes compilation warnings
from things turned off in the kernel code, such as differences in
variable signedness. Fix those issues.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>

convert a couple ASSERT converted to warn/exits, variable sign correction, non-DEBUG unused variable, default string value.
Don't see the significance of the initialization of variables in xfs_da3_split() and xfs_rtfree_range().

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 13/49] libxfs: fix compile warnings, Mark Tinguely <=