[Top] [All Lists]

Re: [PATCH 06/49] libxfs: fix byte swapping on constants

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/49] libxfs: fix byte swapping on constants
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 02 Aug 2013 08:51:52 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374216324-8781-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1374216324-8781-1-git-send-email-david@xxxxxxxxxxxxx> <1374216324-8781-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:44, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The kernel code uses cpu_to_beXX() on constants in switch()
statements for magic numbers in the btree code. Th ebyte swapping
infratructure isn't hooked up to the proper byte swap macros to make
this work, so fix it and then swap all the generic btree code over
to match the kernel code.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>

sync to include/uapi/linux/swab.h and (IMO backwards) switch/case statements in xfs_allocbt_verify() like kernel commit ee1a47ab.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>