xfs
[Top] [All Lists]

Re: [PATCH 28/48] libxfs: determine inode size from version number, not

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 28/48] libxfs: determine inode size from version number, not struct xfs_dinode
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 1 Aug 2013 16:32:42 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1370564771-4929-29-git-send-email-david@xxxxxxxxxxxxx>
References: <1370564771-4929-1-git-send-email-david@xxxxxxxxxxxxx> <1370564771-4929-29-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jun 07, 2013 at 10:25:51AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db does not use the same structure types as libxfs when checking
> inodes, and so cannot determine the size of the inode core by
> passing a struct xfs_dinode to a function. We do, however, know the
> raw version number, so we can pass that instead. Convert the code to
> passing the inode version rather than a structure.
> 
> Note that this should probably be converted in the kernel code as
> well.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 28/48] libxfs: determine inode size from version number, not struct xfs_dinode, Ben Myers <=