[Top] [All Lists]

[PATCH v8 0/7] userns: Convert xfs to use kuid_t/kgid_t where appropriat

To: xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, Gao feng <gaofeng@xxxxxxxxxxxxxx>
Subject: [PATCH v8 0/7] userns: Convert xfs to use kuid_t/kgid_t where appropriate
From: Dwight Engen <dwight.engen@xxxxxxxxxx>
Date: Thu, 1 Aug 2013 11:29:53 -0400
Cc: Serge Hallyn <serge.hallyn@xxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Organization: Oracle Corporation
Hi All,

This updated patchset is on top of 7a378c9a (HEAD) of xfs git. The
patches do not convert the id's returned from bulkstat, since bulkstat
cannot be called from inside a userns right now anyway since the caller
must be CAP_SYS_ADMIN in init_user_ns. Similar checks ensure that
open_by_handle, and changing of projid can also only be called from

Changes since v7 patchset
- 0003 only allow setting of projid from init_user_ns
- 0006 change readonly check from IS_RDONLY to xfs style

Changes since v6 patchset (addressing Dave's comments)
- 0006 just do a capable(CAP_SYS_ADMIN) check for XFS_IOC_FREE_EOFBLOCKS

Changes since v5 patchset (addressing Brian's comments,
only 0005 and 0006 are changed):
 - 0005 put all eofblocks validation in xfs_fs_eofblocks_from_user()
 - 0006 don't export internal flag, add K to internal flag name,
   start internal flags bits at msb (with the intention that other internal
   flags would be in descending order) and ensure that it doesn't accidentally
   collide with external flags

Changes since v4 patchset (addressing Dave's comments):
 - add parenthesis in if with binary and logical and (EOFBLOCKS flags)
 - rename xfs_fs_eofblocks_to_internal -> xfs_fs_eofblocks_from_user and
   move conversion validation into it
 - fix negative error returns from XFS_IOC_FREE_EOFBLOCKS
 - add check for read-only filesystem to XFS_IOC_FREE_EOFBLOCKS

Changes since v3 patchset:
 - export inode_capable() for building xfs as a module
 - implement Brian's proposal for an internal flag to indicate to
   xfs_inode_free_eofblocks() that it should do a permission check.
   ioctl callers will always set this flag, which is simpler than
   making them specify XFS_EOF_FLAGS_UID or XFS_EOF_FLAGS_GID,
   internal callers can leave it unset so no permission checking is
 - take Brian's suggestion on moving the policy from the conversion
   function into the ioctl code, and moving stuff to xfs_icache.h

<Prev in Thread] Current Thread [Next in Thread>