xfs
[Top] [All Lists]

Re: [PATCH] xfs: free bp in xlog_find_zeroed() error path

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: free bp in xlog_find_zeroed() error path
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 01 Aug 2013 09:10:56 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51F9BAAE.2000709@xxxxxxxxxx>
References: <51F9BAAE.2000709@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/31/13 20:32, Eric Sandeen wrote:
xlog_find_zeroed() currently leaks a bp on one error path.

Using the bp_err: target resolves this.

Found by Coverity.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---


Looks good.


p.s. this can be merged to userspace as well.

or get it in before the 3.12 series gets rebased.


Reviewed-by; Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>