xfs
[Top] [All Lists]

Re: [PATCH 02/49] xfs: split out inode log item format definition

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 02/49] xfs: split out inode log item format definition
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 1 Aug 2013 01:50:24 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51F7E7BF.6020108@xxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-3-git-send-email-david@xxxxxxxxxxxxx> <51F7E7BF.6020108@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> >+} xfs_icdinode_t;
> 
> 
> A log header file does not strike me as the place for the internal
> representation of the on disk inode structure.

It's not not really the in-core version, I just messed up the name when
doing the proper endianess annotations for XFS many years ago.

The correct name would be xfs_log_inode or similar.  Maybe the comments
should get a little update.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 02/49] xfs: split out inode log item format definition, Christoph Hellwig <=