xfs
[Top] [All Lists]

[PATCH] xfstests: generic/315: allow a little tolerance for our used che

To: <linux-btrfs@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <jeff.liu@xxxxxxxxxx>, <sandeen@xxxxxxxxxx>
Subject: [PATCH] xfstests: generic/315: allow a little tolerance for our used check
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Mon, 29 Jul 2013 14:55:56 -0400
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1375124159; bh=QTOxs06CQDzbZkNKAVn5R8U9nbAL2vf1E6UwPjaxspc=; h=From:To:Subject:Date; b=nTprhO3XVimf4aViryn/U623AsQ58FUp5nt228Tqtw3NDNxkpJCliVFkB5ccZ4VKh RF3mVB6O4dHo5x7Wbj5JC+2M13aMBqdJCr4mbtsSQ73RrlIRCNyV+9+J0fOR8dIMfn /2W2Ni8uHakQPMzafHuThw1P09Mq8qBmHC/0VCj8=
So df in btrfs is tricky at best, and relying on it for accurate information is
not great, but it's the best way to verify this test.  To get around btrfs being
inconsistent sometimes just use _within_tolerance to check our new df value to
make sure that our truncate did something.  With this patch I no longer see
transient failures of this test.  Thanks,

Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
---
 tests/generic/315 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tests/generic/315 b/tests/generic/315
index 7cfc40d..9c01b5e 100644
--- a/tests/generic/315
+++ b/tests/generic/315
@@ -73,7 +73,8 @@ sync
 
 # Preallocated disk space should be released
 avail_done=`df -P $TEST_DIR | awk 'END {print $4}'`
-[ "$avail_done" -eq "$avail_begin" ] || _fail "Available disk space 
($avail_done KiB)"
+_within_tolerance "df" $avail_done $avail_begin 1%
+[ $? -eq 0 ] || _fail "Available disk space ($avail_done KiB) wanted 
($avail_begin KiB)"
 
 # success, all done
 exit
-- 
1.7.7.6

<Prev in Thread] Current Thread [Next in Thread>