xfs
[Top] [All Lists]

Re: [PATCH] xfstests: generic/315: add one more sync and more output

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: generic/315: add one more sync and more output
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Mon, 29 Jul 2013 14:25:25 -0400
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxxxx>, <jeff.liu@xxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1375122327; bh=OzfNznukr4GyQa1FlOZGZ064IC6Vwcen8eBg8Bm1mEw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=kqWJIWVw0agm9ewDqMRI937NyQ5lOebEqWxcHXTRI847O5Xm86aJKz9x8qwCS3ic+ 4xRp5CHLYWbaljKahuFpO292V9niAQgUY1CZ9MI3g8tnusd7ozat0RZ989E0DStbHa 7BdScTNjF24QNd++32K13aCznDIFHKhGxzvZ/6J4=
In-reply-to: <51F6A891.7070608@xxxxxxxxxxx>
References: <1375118463-29654-1-git-send-email-jbacik@xxxxxxxxxxxx> <51F6A6DA.3080102@xxxxxxxxxx> <51F6A891.7070608@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
On Mon, Jul 29, 2013 at 12:38:25PM -0500, Eric Sandeen wrote:
> On 7/29/13 12:31 PM, Eric Sandeen wrote:
> > Honest question: does one more sync make this deterministic, or is it a 
> > best-effort, um, hack?
> 
> I'm not quite sure why even 1 sync is needed.  :(
> 

Because of COW, we won't free up the data space until the transaction commits
because it is pinned, so doing the truncate and then immediately doing df will
show no difference.

> I'm not sure what bug this is trying to test; if you need 2 syncs for global 
> space stats to accurately reflect the fact that you chopped off the end of a 
> block, maybe that's ... still a bug?
> 

No, it's just COW for you, in this case we do our sync, stuff gets updated and
some metadata is cow'ed for once reason or another and now df doesn't quite
match up (in my case it was off by like 9 blocks), doing a second sync clears
these out and then df's match.

> Or if it's just the big-hammer question of "does the truncated space *ever* 
> get freed?" then maybe umount/remount/check would tell you that more 
> definitively.

Yeah but I think I'll do what you suggested on IRC and just use _within_range.
Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>