xfs
[Top] [All Lists]

Re: [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Sat, 27 Jul 2013 12:54:02 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1374215120-7271-21-git-send-email-david@xxxxxxxxxxxxx>
References: <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-21-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/19/13 01:24, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

xfs_mount.c is shared with userspace, but the only functions that
are shared are to do with physical superblock manipulations. This
means that less than 25% of the xfs_mount.c code is actually shared
with userspace. Move all the superblock functions to xfs_sb.c and
share that instead with libxfs.

Note that this will leave all the in-core transaction related
superblock counter modifications in xfs_mount.c as none of that is
shared with userspace. With a few more small changes, xfs_mount.h
won't need to be shared with userspace anymore, either.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

okay, moves the user sharable functions/headers from xfs_mount.c/h to
 xfs_sb.c/h

couple comments:

  a struct xfs_mount got converted to a xfs_mount_t typedef in
  xfs_initialize_perag() def in xfs_mount.h

 brackets were added to a single line if statements in
 xfs_sb_quota_from_disk()

beyond these two comments consider it:

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>